feat: add selected process detail strip - #196
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e38eacf76
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (externalPanel) { | ||
| sideColumn.add(externalPanel); | ||
| } | ||
| outputColumn.add(servicePanel); |
There was a problem hiding this comment.
When the user toggles the logs panel off (or it is hidden because there is not enough width), applyLayout only updates logPanel.visible, while this newly added servicePanel remains visible inside outputColumn. That leaves a Process strip rendered even though getRenderedPanels() no longer includes logs, so the UI can show and allocate space for an output-related panel that focus/shortcuts report as hidden.
Useful? React with 👍 / 👎.
| return { pid, cpuPercent: null, rssBytes: snapshot.rssBytes, sampledAt: snapshot.sampledAt }; | ||
| } | ||
|
|
||
| const cpuTicks = Math.max(0, snapshot.totalCpuTicks - previous.totalCpuTicks); |
There was a problem hiding this comment.
For process trees with short-lived child processes, subtracting only the aggregate tree CPU total undercounts or zeroes CPU after a child exits between samples: the previous snapshot includes the exited child's lifetime ticks, but the next snapshot does not, so Math.max(0, currentTotal - previousTotal) can discard CPU used by the still-running root and remaining children. This makes the displayed Cpu value misleading for services that spawn workers or one-shot subprocesses.
Useful? React with 👍 / 👎.
|
Addressed Codex feedback: the Process strip now hides with the Logs panel, and CPU deltas are calculated per surviving process with regression coverage for exited children. CI is green. |
1 similar comment
|
Addressed Codex feedback: the Process strip now hides with the Logs panel, and CPU deltas are calculated per surviving process with regression coverage for exited children. CI is green. |
# Conflicts: # src/ui.ts
1 participant
Closes #185
Closes #186
Closes #187
Closes #188
Closes #189
Summary
Tests
Self-reviewed diff for scope, secrets, debug logs, and acceptance criteria.